yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

kwin: Static member variables shouldn't have the m prefix.

Browse source
This commit is contained in:
Fredrik Höglund 2011-02-04 17:30:36 +01:00 committed by Marco Martin
parent cf58a57cf4
commit 5cbd1d458b
2 changed files with 31 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
lib/kwinglutils.cpp
View file

@ -357,9 +357,9 @@ void popMatrix()
// GLTexture // GLTexture
//**************************************** //****************************************
bool GLTexture::mNPOTTextureSupported = false; bool GLTexture::sNPOTTextureSupported = false;
bool GLTexture::mFramebufferObjectSupported = false; bool GLTexture::sFramebufferObjectSupported = false;
bool GLTexture::mSaturationSupported = false; bool GLTexture::sSaturationSupported = false;
GLTexture::GLTexture() GLTexture::GLTexture()
{ {
@ -432,13 +432,13 @@ void GLTexture::init()
void GLTexture::initStatic() void GLTexture::initStatic()
{ {
#ifdef KWIN_HAVE_OPENGLES #ifdef KWIN_HAVE_OPENGLES
mNPOTTextureSupported = true; sNPOTTextureSupported = true;
mFramebufferObjectSupported = true; sFramebufferObjectSupported = true;
mSaturationSupported = true; sSaturationSupported = true;
#else #else
mNPOTTextureSupported = hasGLExtension("GL_ARB_texture_non_power_of_two"); sNPOTTextureSupported = hasGLExtension("GL_ARB_texture_non_power_of_two");
mFramebufferObjectSupported = hasGLExtension("GL_EXT_framebuffer_object"); sFramebufferObjectSupported = hasGLExtension("GL_EXT_framebuffer_object");
mSaturationSupported = ((hasGLExtension("GL_ARB_texture_env_crossbar") sSaturationSupported = ((hasGLExtension("GL_ARB_texture_env_crossbar")
&& hasGLExtension("GL_ARB_texture_env_dot3")) || hasGLVersion(1, 4)) && hasGLExtension("GL_ARB_texture_env_dot3")) || hasGLVersion(1, 4))
&& (glTextureUnitsCount >= 4) && glActiveTexture != NULL; && (glTextureUnitsCount >= 4) && glActiveTexture != NULL;
#endif #endif
@ -813,18 +813,18 @@ QImage GLTexture::convertToGLFormat(const QImage& img) const
// GLShader // GLShader
//**************************************** //****************************************
bool GLShader::mFragmentShaderSupported = false; bool GLShader::sFragmentShaderSupported = false;
bool GLShader::mVertexShaderSupported = false; bool GLShader::sVertexShaderSupported = false;
void GLShader::initStatic() void GLShader::initStatic()
{ {
#ifdef KWIN_HAVE_OPENGLES #ifdef KWIN_HAVE_OPENGLES
mFragmentShaderSupported = mVertexShaderSupported = true; sFragmentShaderSupported = sVertexShaderSupported = true;
#else #else
mFragmentShaderSupported = mVertexShaderSupported = sFragmentShaderSupported = sVertexShaderSupported =
hasGLExtension("GL_ARB_shader_objects") && hasGLExtension("GL_ARB_shading_language_100"); hasGLExtension("GL_ARB_shader_objects") && hasGLExtension("GL_ARB_shading_language_100");
mVertexShaderSupported &= hasGLExtension("GL_ARB_vertex_shader"); sVertexShaderSupported &= hasGLExtension("GL_ARB_vertex_shader");
mFragmentShaderSupported &= hasGLExtension("GL_ARB_fragment_shader"); sFragmentShaderSupported &= hasGLExtension("GL_ARB_fragment_shader");
#endif #endif
} }
@ -1382,14 +1382,14 @@ void ShaderManager::resetShader(ShaderType type)
} }
/*** GLRenderTarget ***/ /*** GLRenderTarget ***/
bool GLRenderTarget::mSupported = false; bool GLRenderTarget::sSupported = false;
void GLRenderTarget::initStatic() void GLRenderTarget::initStatic()
{ {
#ifdef KWIN_HAVE_OPENGLES #ifdef KWIN_HAVE_OPENGLES
mSupported = true; sSupported = true;
#else #else
mSupported = hasGLExtension("GL_EXT_framebuffer_object") && glFramebufferTexture2D; sSupported = hasGLExtension("GL_EXT_framebuffer_object") && glFramebufferTexture2D;
#endif #endif
} }
@ -1401,7 +1401,7 @@ GLRenderTarget::GLRenderTarget(GLTexture* color)
mTexture = color; mTexture = color;
// Make sure FBO is supported // Make sure FBO is supported
if (mSupported && mTexture && !mTexture->isNull()) { if (sSupported && mTexture && !mTexture->isNull()) {
initFBO(); initFBO();
} else } else
kError(1212) << "Render targets aren't supported!" << endl; kError(1212) << "Render targets aren't supported!" << endl;

24
lib/kwinglutils.h
View file

@ -249,13 +249,13 @@ public:
static void initStatic(); static void initStatic();
static bool NPOTTextureSupported() { static bool NPOTTextureSupported() {
return mNPOTTextureSupported; return sNPOTTextureSupported;
} }
static bool framebufferObjectSupported() { static bool framebufferObjectSupported() {
return mFramebufferObjectSupported; return sFramebufferObjectSupported;
} }
static bool saturationSupported() { static bool saturationSupported() {
return mSaturationSupported; return sSaturationSupported;
} }
protected: protected:
@ -278,9 +278,9 @@ private:
GLVertexBuffer* m_vbo; GLVertexBuffer* m_vbo;
QSize m_cachedSize; QSize m_cachedSize;
static bool mNPOTTextureSupported; static bool sNPOTTextureSupported;
static bool mFramebufferObjectSupported; static bool sFramebufferObjectSupported;
static bool mSaturationSupported; static bool sSaturationSupported;
Q_DISABLE_COPY(GLTexture) Q_DISABLE_COPY(GLTexture)
}; };
@ -317,10 +317,10 @@ public:
static void initStatic(); static void initStatic();
static bool fragmentShaderSupported() { static bool fragmentShaderSupported() {
return mFragmentShaderSupported; return sFragmentShaderSupported;
} }
static bool vertexShaderSupported() { static bool vertexShaderSupported() {
return mVertexShaderSupported; return sVertexShaderSupported;
} }
@ -336,8 +336,8 @@ protected:
private: private:
unsigned int mProgram; unsigned int mProgram;
bool mValid; bool mValid;
static bool mFragmentShaderSupported; static bool sFragmentShaderSupported;
static bool mVertexShaderSupported; static bool sVertexShaderSupported;
float mTextureWidth; float mTextureWidth;
float mTextureHeight; float mTextureHeight;
friend class ShaderManager; friend class ShaderManager;
@ -520,7 +520,7 @@ public:
static void initStatic(); static void initStatic();
static bool supported() { static bool supported() {
return mSupported; return sSupported;
} }
@ -529,7 +529,7 @@ protected:
private: private:
static bool mSupported; static bool sSupported;
GLTexture* mTexture; GLTexture* mTexture;
bool mValid; bool mValid;