yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[libkwineffects] Don't expose the fullscreen effect lock to the public API

Browse source 
Summary:
The fullscreen effect lock is purely an implementation detail of the
AnimationEffect, we don't need to have it in the public API.

Test Plan: KWin still compiles.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16075
This commit is contained in:
Vlad Zagorodniy 2018-10-09 18:44:07 +03:00
parent 27bf348583
commit 5d5816be2b
4 changed files with 24 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libkwineffects/anidata.cpp
View file

@ -31,6 +31,16 @@ QDebug operator<<(QDebug dbg, const KWin::AniData &a)
using namespace KWin; using namespace KWin;
static const int Gaussian = 46; static const int Gaussian = 46;
FullScreenEffectLock::FullScreenEffectLock(Effect *effect)
{
effects->setActiveFullScreenEffect(effect);
}
FullScreenEffectLock::~FullScreenEffectLock()
{
effects->setActiveFullScreenEffect(nullptr);
}
AniData::AniData() AniData::AniData()
: attribute(AnimationEffect::Opacity) : attribute(AnimationEffect::Opacity)
, customCurve(0) // Linear , customCurve(0) // Linear

14
libkwineffects/anidata_p.h
View file

@ -27,6 +27,20 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
namespace KWin { namespace KWin {
/**
* Wraps effects->setActiveFullScreenEffect for the duration of it's lifespan
*/
class FullScreenEffectLock
{
public:
FullScreenEffectLock(Effect *effect);
~FullScreenEffectLock();
private:
Q_DISABLE_COPY(FullScreenEffectLock)
void *d; //unused currently
};
typedef QSharedPointer<FullScreenEffectLock> FullScreenEffectLockPtr;
class KWINEFFECTS_EXPORT AniData { class KWINEFFECTS_EXPORT AniData {
public: public:
AniData(); AniData();

10
libkwineffects/kwinanimationeffect.cpp
View file

@ -965,14 +965,4 @@ AnimationEffect::AniMap AnimationEffect::state() const
return d->m_animations; return d->m_animations;
} }
FullScreenEffectLock::FullScreenEffectLock(Effect *effect)
{
effects->setActiveFullScreenEffect(effect);
}
FullScreenEffectLock::~FullScreenEffectLock()
{
effects->setActiveFullScreenEffect(nullptr);
}
#include "moc_kwinanimationeffect.cpp" #include "moc_kwinanimationeffect.cpp"

14
libkwineffects/kwinanimationeffect.h
View file

@ -88,20 +88,6 @@ private:
bool valid; bool valid;
}; };
/**
* Wraps effects->setActiveFullScreenEffect for the duration of it's lifespan
*/
class FullScreenEffectLock
{
public:
FullScreenEffectLock(Effect *effect);
~FullScreenEffectLock();
private:
Q_DISABLE_COPY(FullScreenEffectLock)
void *d; //unused currently
};
typedef QSharedPointer<FullScreenEffectLock> FullScreenEffectLockPtr;
class AniData; class AniData;
class AnimationEffectPrivate; class AnimationEffectPrivate;
class KWINEFFECTS_EXPORT AnimationEffect : public Effect class KWINEFFECTS_EXPORT AnimationEffect : public Effect