yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

effects/mousemark: Port away from KPluralHandlingSpinBox

Browse source 
It's the only user of KTextWidgets in the entire repository.

Signed-off-by: Eike Hein <eike.hein@mbition.io>
This commit is contained in:
Kai Uwe Broulik 2022-02-23 09:28:03 +01:00 committed by Kai Uwe Broulik
parent 8f21921843
commit 5db527a053
5 changed files with 19 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CMakeLists.txt
View file

@ -90,7 +90,6 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
KCMUtils
NewStuff
Service
TextWidgets
XmlGui
)

1
src/effects/mousemark/CMakeLists.txt
View file

@ -33,7 +33,6 @@ target_link_libraries(kwin_mousemark_config
KF5::CoreAddons
KF5::GlobalAccel
KF5::I18n
KF5::TextWidgets
KF5::XmlGui
KWinEffectsInterface
)

18
src/effects/mousemark/mousemark_config.cpp
View file

@ -39,8 +39,6 @@ MouseMarkEffectConfig::MouseMarkEffectConfig(QWidget* parent, const QVariantList
{
m_ui = new MouseMarkEffectConfigForm(this);
m_ui->kcfg_LineWidth->setSuffix(ki18ncp("Suffix", " pixel", " pixels"));
QVBoxLayout* layout = new QVBoxLayout(this);
layout->addWidget(m_ui);
@ -66,7 +64,9 @@ MouseMarkEffectConfig::MouseMarkEffectConfig(QWidget* parent, const QVariantList
m_ui->editor->addCollection(m_actionCollection);
load();
connect(m_ui->kcfg_LineWidth, qOverload<int>(&QSpinBox::valueChanged), this, [this]() {
updateSpinBoxSuffix();
});
}
MouseMarkEffectConfig::~MouseMarkEffectConfig()
@ -75,6 +75,13 @@ MouseMarkEffectConfig::~MouseMarkEffectConfig()
m_ui->editor->undo();
}
void MouseMarkEffectConfig::load()
{
KCModule::load();
updateSpinBoxSuffix();
}
void MouseMarkEffectConfig::save()
{
qDebug() << "Saving config of MouseMark" ;
@ -89,6 +96,11 @@ void MouseMarkEffectConfig::save()
interface.reconfigureEffect(QStringLiteral("mousemark"));
}
void MouseMarkEffectConfig::updateSpinBoxSuffix()
{
m_ui->kcfg_LineWidth->setSuffix(i18ncp("Suffix", " pixel", " pixels", m_ui->kcfg_LineWidth->value()));
}
} // namespace
#include "mousemark_config.moc"

3
src/effects/mousemark/mousemark_config.h
View file

@ -33,9 +33,12 @@ public:
explicit MouseMarkEffectConfig(QWidget* parent = nullptr, const QVariantList& args = QVariantList());
~MouseMarkEffectConfig() override;
void load() override;
void save() override;
private:
void updateSpinBoxSuffix();
MouseMarkEffectConfigForm* m_ui;
KActionCollection* m_actionCollection;
};

7
src/effects/mousemark/mousemark_config.ui
View file

@ -54,7 +54,7 @@
</widget>
</item>
<item row="1" column="1">
<widget class="KPluralHandlingSpinBox" name="kcfg_LineWidth">
<widget class="QSpinBox" name="kcfg_LineWidth">
<property name="minimum">
<number>1</number>
</property>
@ -103,11 +103,6 @@
<header>kshortcutseditor.h</header>
<container>1</container>
</customwidget>
<customwidget>
<class>KPluralHandlingSpinBox</class>
<extends>QSpinBox</extends>
<header>kpluralhandlingspinbox.h</header>
</customwidget>
</customwidgets>
<resources/>
<connections/>