From 5eaf46c24803a00ff7aa6ee36d0a8934ff5e7882 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Mon, 25 Jan 2021 16:19:07 +0200 Subject: [PATCH] wayland: Don't call updateDecoration() for popups After lowering the message severity for the KWIN_CORE logging category, it has been found that the Workspace calls the updateDecoration() method for every mapped popup surface. Since the XdgPopupClient doesn't implement that method, a warning message is printed every time a popup is mapped. Given that XdgToplevelClient updates the decoration when needed, we can remove the call to the updateDecoration() method. --- workspace.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/workspace.cpp b/workspace.cpp index 7982cd319c..d701525b63 100644 --- a/workspace.cpp +++ b/workspace.cpp @@ -712,7 +712,6 @@ void Workspace::removeDeleted(Deleted* c) void Workspace::addShellClient(AbstractClient *client) { setupClientConnections(client); - client->updateDecoration(false); updateClientLayer(client); if (client->isPlaceable()) {