From 6006dab41c47da62db17ef2d5df846737a3daa76 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Sun, 13 Jan 2019 23:25:43 +0200 Subject: [PATCH] Use correct flag when checking whether a scene window is opaque Summary: Given that allclips contains opaque regions of higher windows, we should check PAINT_WINDOW_TRANSLUCENT flag instead of PAINT_WINDOW_TRANSFORMED. ba39d1f917c61aff02e84088fc3f3091f0eb977e introduced that check. Neither the commit message nor the associated review have any comments regarding checking PAINT_WINDOW_TRANSFORMED, so given the following comment // Here we rely on WindowPrePaintData::setTranslucent() to remove // the clip if needed. PAINT_WINDOW_TRANSFORMED is most likely a typo. Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: graesslin, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D18236 --- scene.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scene.cpp b/scene.cpp index 3c4edbab8e..327042906e 100644 --- a/scene.cpp +++ b/scene.cpp @@ -345,7 +345,7 @@ void Scene::paintSimpleScreen(int orig_mask, QRegion region) // Here we rely on WindowPrePaintData::setTranslucent() to remove // the clip if needed. - if (!data->clip.isEmpty() && !(data->mask & PAINT_WINDOW_TRANSFORMED)) { + if (!data->clip.isEmpty() && !(data->mask & PAINT_WINDOW_TRANSLUCENT)) { // clip away the opaque regions for all windows below this one allclips |= data->clip; // extend the translucent damage for windows below this by remaining (translucent) regions