From 6142ecbfe0eee4d0b12a6ee5e8eb84038487412c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Wed, 7 May 2008 12:54:23 +0000 Subject: [PATCH] paintTransformedScreen() is broken, disable its usage. svn path=/trunk/KDE/kdebase/workspace/; revision=805050 --- COMPOSITE_TODO | 1 + scene_xrender.cpp | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/COMPOSITE_TODO b/COMPOSITE_TODO index 24dbeab560..0b7f68f7d9 100644 --- a/COMPOSITE_TODO +++ b/COMPOSITE_TODO @@ -155,6 +155,7 @@ XRender TODO + SceneXrender::paintTransformedScreen() doesn't handle properly extending of painted area in window's pre-paint - see the transformedShape() comment + - and currently seems to be generally broken Effects framework TODO diff --git a/scene_xrender.cpp b/scene_xrender.cpp index fb116cdcda..b68db4fc71 100644 --- a/scene_xrender.cpp +++ b/scene_xrender.cpp @@ -183,13 +183,14 @@ void SceneXrender::paint( QRegion damage, ToplevelList toplevels ) void SceneXrender::paintGenericScreen( int mask, ScreenPaintData data ) { screen_paint = data; // save, transformations will be done when painting windows - if( false ) // TODO never needed? + if( true ) // as long as paintTransformedScreen() doesn't work properly Scene::paintGenericScreen( mask, data ); else paintTransformedScreen( mask ); } /* + TODO currently broken Try to do optimized painting even with transformations. Since only scaling and translation are supported by the painting code, clipping can be done manually to avoid having to paint everything in every pass. Whole screen