yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't pass any arguments to AbstractClient::doSetDesktop()

Browse source 
Summary: We don't use them anywhere.

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D27121
This commit is contained in:
Vlad Zahorodnii 2020-02-03 02:19:46 +02:00
parent f9e9f93d5b
commit 624317a78d
4 changed files with 5 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
abstract_client.cpp
View file

@ -475,7 +475,7 @@ void AbstractClient::setDesktops(QVector<VirtualDesktop*> desktops)
c2->setDesktops(desktops);
}
doSetDesktop(desktop(), was_desk);
doSetDesktop();
FocusChain::self()->update(this, FocusChain::MakeFirst);
updateWindowRules(Rules::Desktop);
@ -486,10 +486,8 @@ void AbstractClient::setDesktops(QVector<VirtualDesktop*> desktops)
emit x11DesktopIdsChanged();
}
void AbstractClient::doSetDesktop(int desktop, int was_desk)
void AbstractClient::doSetDesktop()
{
Q_UNUSED(desktop)
Q_UNUSED(was_desk)
}
void AbstractClient::enterDesktop(VirtualDesktop *virtualDesktop)

4
abstract_client.h
View file

@ -968,10 +968,8 @@ protected:
* is emitted.
*
* Default implementation does nothing.
* @param desktop The new desktop the Client is on
* @param was_desk The desktop the Client was on before
*/
virtual void doSetDesktop(int desktop, int was_desk);
virtual void doSetDesktop();
/**
* Called from @ref minimize and @ref unminimize once the minimized value got updated, but before the
* changed signal is emitted.

4
x11client.cpp
View file

@ -1925,10 +1925,8 @@ void X11Client::doSetSkipSwitcher()
info->setState(skipSwitcher() ? NET::SkipSwitcher : NET::States(), NET::SkipSwitcher);
}
void X11Client::doSetDesktop(int desktop, int was_desk)
void X11Client::doSetDesktop()
{
Q_UNUSED(desktop)
Q_UNUSED(was_desk)
updateVisibility();
}

2
x11client.h
View file

@ -360,7 +360,7 @@ protected:
void doSetActive() override;
void doSetKeepAbove() override;
void doSetKeepBelow() override;
void doSetDesktop(int desktop, int was_desk) override;
void doSetDesktop() override;
void doMinimize() override;
void doSetSkipPager() override;
void doSetSkipTaskbar() override;