yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop openoffice.org 1.x related hack for windowType detection

Browse source 
The oo.o related hack can be removed for several reasons:
1. The dialog in question from bug 66065 is nowadays a utility
2. The window class name changed to libreoffice
3. It's not the task of the window manager to workaround bugs in Clients

CCBUG: 66065
BUG: 306383
FIXED-IN: 4.9.2
This commit is contained in:
Martin Gräßlin 2012-09-06 08:11:47 +02:00
parent a38e87afea
commit 633694b7b4
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
toplevel.cpp
View file

@ -173,11 +173,6 @@ NET::WindowType Toplevel::windowType(bool direct, int supported_types) const
info->setWindowType(wt); // force hint change
}
// hacks here
// TODO change this to rule
const char* const oo_prefix = "openoffice.org"; // QByteArray has no startsWith()
// oo_prefix is lowercase, because resourceClass() is forced to be lowercase
if (qstrncmp(resourceClass(), oo_prefix, strlen(oo_prefix)) == 0 && wt == NET::Dialog)
wt = NET::Normal; // see bug #66065
if (wt == NET::Unknown && cl != NULL) // this is more or less suggested in NETWM spec
wt = cl->isTransient() ? NET::Dialog : NET::Normal;
return wt;