From 63a0120a6020b31b6b9ca247222c53d3df50d838 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Thu, 19 Jul 2007 16:38:46 +0000 Subject: [PATCH] Remove some no longer relevant todos. svn path=/trunk/KDE/kdebase/workspace/; revision=689955 --- activation.cpp | 1 - client.cpp | 2 +- events.cpp | 3 +-- manage.cpp | 6 +++--- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/activation.cpp b/activation.cpp index 6dd0a818e2..197e8cdc3a 100644 --- a/activation.cpp +++ b/activation.cpp @@ -862,7 +862,6 @@ void Client::setActive( bool act ) StackingUpdatesBlocker blocker( workspace()); workspace()->updateClientLayer( this ); // active windows may get different layer - // TODO optimize? mainClients() may be a bit expensive ClientList mainclients = mainClients(); for( ClientList::ConstIterator it = mainclients.begin(); it != mainclients.end(); diff --git a/client.cpp b/client.cpp index 17efe6b437..b83dc1446d 100644 --- a/client.cpp +++ b/client.cpp @@ -1097,7 +1097,7 @@ void Client::killProcess( bool ask, Time timestamp ) ::kill( pid, SIGTERM ); } else - { // SELI TODO handle the window created by handler specially (on top,urgent?) + { process_killer = new K3Process( this ); *process_killer << KStandardDirs::findExe( "kwin_killer_helper" ) << "--pid" << QByteArray().setNum( pid ) << "--hostname" << machine diff --git a/events.cpp b/events.cpp index 1ea2465fb7..d66b3f6d79 100644 --- a/events.cpp +++ b/events.cpp @@ -595,7 +595,6 @@ bool Client::windowEvent( XEvent* e ) } } -// TODO move all focus handling stuff to separate file? switch (e->type) { case UnmapNotify: @@ -870,7 +869,7 @@ void Client::configureRequestEvent( XConfigureRequestEvent* e ) if ( e->value_mask & CWStackMode ) restackWindow( e->above, e->detail, NET::FromApplication, userTime(), false ); - // TODO sending a synthetic configure notify always is fine, even in cases where + // Sending a synthetic configure notify always is fine, even in cases where // the ICCCM doesn't require this - it can be though of as 'the WM decided to move // the window later'. The client should not cause that many configure request, // so this should not have any significant impact. With user moving/resizing diff --git a/manage.cpp b/manage.cpp index de182fc125..3f1f805dd2 100644 --- a/manage.cpp +++ b/manage.cpp @@ -247,12 +247,12 @@ bool Client::manage( Window w, bool isMapped ) if( mainClients().count() >= 1 ) { #if 1 - // TODO #78082 - Ok, it seems there are after all some cases when an application has a good + // #78082 - Ok, it seems there are after all some cases when an application has a good // reason to specify a position for its dialog. Too bad other WMs have never bothered // with placement for dialogs, so apps always specify positions for their dialogs, // including such silly positions like always centered on the screen or under mouse. - // Using ignoring requested position in window-specific settings helps, but at least - // for Qt apps this should work better. + // Using ignoring requested position in window-specific settings helps, and now + // there's also _NET_WM_FULL_PLACEMENT. usePosition = true; #else ; // force using placement policy