From 646954ed9d279018fe2ca67be562241252939738 Mon Sep 17 00:00:00 2001 From: Jaime Torres Date: Tue, 2 Aug 2011 17:24:38 +0200 Subject: [PATCH] rules must never be null if rules were null, it was pointing to a local structure, prabably a crash after leaving if rules where used. REVIEW: 102057 --- kcmkwin/kwinrules/ruleswidget.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kcmkwin/kwinrules/ruleswidget.cpp b/kcmkwin/kwinrules/ruleswidget.cpp index c3a44df185..d79ab30576 100644 --- a/kcmkwin/kwinrules/ruleswidget.cpp +++ b/kcmkwin/kwinrules/ruleswidget.cpp @@ -384,8 +384,9 @@ static NET::WindowType comboToType(int val) void RulesWidget::setRules(Rules* rules) { Rules tmp; - if (rules == NULL) - rules = &tmp; // empty + + Q_ASSERT( rules ); + description->setText(rules->description); wmclass->setText(rules->wmclass); whole_wmclass->setChecked(rules->wmclasscomplete);