++ prefix for non-trivial data-types

change suffix ++ to prefix ++ to speed up a little bit not-trivial
data-types. discovered by cppcheck

REVIEW: 102057

clientgroup.cpp

@@ -270,7 +270,7 @@ void ClientGroup::setVisible(Client* c)
 
 void ClientGroup::updateStates(Client* main, Client* only)
 {
-    for (ClientList::const_iterator i = clients_.constBegin(); i != clients_.constEnd(); i++)
+    for (ClientList::const_iterator i = clients_.constBegin(); i != clients_.constEnd(); ++i)
         if ((*i) != main && (!only || (*i) == only)) {
             if ((*i)->isMinimized() != main->isMinimized()) {
                 if (main->isMinimized())

clients/oxygen/oxygenexceptionlist.cpp

@@ -65,7 +65,7 @@ namespace Oxygen
 
         // also add exceptions
         int index(0);
-        for( ExceptionList::const_iterator iter = constBegin(); iter != constEnd(); iter++, index++ )
+        for( ExceptionList::const_iterator iter = constBegin(); iter != constEnd(); ++iter, index++ )
         {
 
             KConfigGroup group( &config, exceptionGroupName( index ) );

effects/presentwindows/presentwindows.cpp

@@ -236,7 +236,7 @@ void PresentWindowsEffect::postPaintScreen()
         while (i != m_windowData.end()) {
             delete i.value().textFrame;
             delete i.value().iconFrame;
-            i++;
+            ++i;
         }
         m_windowData.clear();
 

effects/slidingpopups/slidingpopups.cpp

@@ -58,18 +58,18 @@ void SlidingPopupsEffect::reconfigure(ReconfigureFlags flags)
     QHash< const EffectWindow*, QTimeLine* >::iterator it = mAppearingWindows.begin();
     while (it != mAppearingWindows.end()) {
         it.value()->setDuration(animationTime(mFadeInTime));
-        it++;
+        ++it;
     }
     it = mDisappearingWindows.begin();
     while (it != mDisappearingWindows.end()) {
         it.value()->setDuration(animationTime(mFadeOutTime));
-        it++;
+        ++it;
     }
     QHash< const EffectWindow*, Data >::iterator wIt = mWindowsData.begin();
     while (wIt != mWindowsData.end()) {
         wIt.value().fadeInDuration = mFadeInTime;
         wIt.value().fadeOutDuration = mFadeOutTime;
-        wIt++;
+        ++wIt;
     }
 }
 

libkwineffects/kwineffects.cpp

@@ -847,7 +847,7 @@ void WindowMotionManager::calculate(int time)
         // Just skip it completely if the user wants no animation
         m_movingWindowsSet.clear();
         QHash<EffectWindow*, WindowMotion>::iterator it = m_managedWindows.begin();
-        for (; it != m_managedWindows.end(); it++) {
+        for (; it != m_managedWindows.end(); ++it) {
             WindowMotion *motion = &it.value();
             motion->translation.finish();
             motion->scale.finish();
@@ -855,7 +855,7 @@ void WindowMotionManager::calculate(int time)
     }
 
     QHash<EffectWindow*, WindowMotion>::iterator it = m_managedWindows.begin();
-    for (; it != m_managedWindows.end(); it++) {
+    for (; it != m_managedWindows.end(); ++it) {
         WindowMotion *motion = &it.value();
         EffectWindow *window = it.key();
         int stopped = 0;
@@ -904,7 +904,7 @@ void WindowMotionManager::calculate(int time)
 void WindowMotionManager::reset()
 {
     QHash<EffectWindow*, WindowMotion>::iterator it = m_managedWindows.begin();
-    for (; it != m_managedWindows.end(); it++) {
+    for (; it != m_managedWindows.end(); ++it) {
         WindowMotion *motion = &it.value();
         EffectWindow *window = it.key();
         motion->translation.setTarget(window->pos());

useractions.cpp

@@ -424,7 +424,7 @@ void Workspace::groupTabPopupAboutToShow()
         return;
     add_tabs_popup->clear();
     int index = 0;
-    for (QList<ClientGroup*>::const_iterator i = clientGroups.constBegin(); i != clientGroups.constEnd(); i++, index++) {
+    for (QList<ClientGroup*>::const_iterator i = clientGroups.constBegin(); i != clientGroups.constEnd(); ++i, index++) {
         if (!(*i)->contains(active_popup_client)) {
             QAction* action = add_tabs_popup->addAction((*i)->visible()->caption());
             action->setData(index);

workspace.cpp

@@ -989,7 +989,7 @@ void Workspace::slotReconfigure()
         // If the new decoration doesn't supports tabs then ungroup clients
         if (!decorationSupportsClientGrouping()) {
             QList<ClientGroup*> tmpGroups = clientGroups; // Prevent crashing
-            for (QList<ClientGroup*>::const_iterator i = tmpGroups.constBegin(); i != tmpGroups.constEnd(); i++)
+            for (QList<ClientGroup*>::const_iterator i = tmpGroups.constBegin(); i != tmpGroups.constEnd(); ++i)
                 (*i)->removeAll();
         }
         mgr->destroyPreviousPlugin();