yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xwayland: Remove mysterious Q_FALLTHROUGH macros

Browse source 
We cannot fall through to the next case because `reinterpret_cast`ing
incompatible events is dangerous.
This commit is contained in:
Vlad Zahorodnii 2020-07-29 15:03:49 +03:00 committed by Vlad Zahorodnii
parent def9817a7e
commit 678944ceb8
1 changed files with 4 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
xwl/selection.cpp
View file

@ -127,25 +127,13 @@ bool Selection::filterEvent(xcb_generic_event_t *event)
{ {
switch (event->response_type & XCB_EVENT_RESPONSE_TYPE_MASK) { switch (event->response_type & XCB_EVENT_RESPONSE_TYPE_MASK) {
case XCB_SELECTION_NOTIFY: case XCB_SELECTION_NOTIFY:
if (handleSelectionNotify(reinterpret_cast<xcb_selection_notify_event_t *>(event))) { return handleSelectionNotify(reinterpret_cast<xcb_selection_notify_event_t *>(event));
return true;
}
Q_FALLTHROUGH();
case XCB_PROPERTY_NOTIFY: case XCB_PROPERTY_NOTIFY:
if (handlePropertyNotify(reinterpret_cast<xcb_property_notify_event_t *>(event))) { return handlePropertyNotify(reinterpret_cast<xcb_property_notify_event_t *>(event));
return true;
}
Q_FALLTHROUGH();
case XCB_SELECTION_REQUEST: case XCB_SELECTION_REQUEST:
if (handleSelectionRequest(reinterpret_cast<xcb_selection_request_event_t *>(event))) { return handleSelectionRequest(reinterpret_cast<xcb_selection_request_event_t *>(event));
return true;
}
Q_FALLTHROUGH();
case XCB_CLIENT_MESSAGE: case XCB_CLIENT_MESSAGE:
if (handleClientMessage(reinterpret_cast<xcb_client_message_event_t *>(event))) { return handleClientMessage(reinterpret_cast<xcb_client_message_event_t *>(event));
return true;
}
Q_FALLTHROUGH();
default: default:
return false; return false;
} }