From 6896e960140073510e7c431fbcc6c7c3c6f85ef8 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Mon, 30 Dec 2019 15:44:15 +0000 Subject: [PATCH] [plasmashell] Update docs for panelTakesFocus to make it generic Summary: We want surfaces with a notification role to be able to switch ability to take focus or not on the fly. The semantics are identical as the panel taking focus, we may as well re-use what exists and remove the implicit limitation than re-invent the wheel and complicate things. Test Plan: Docs Reviewers: #kwin, romangg Reviewed By: #kwin, romangg Subscribers: romangg, apol, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D26175 --- src/wayland/plasmashell_interface.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/wayland/plasmashell_interface.h b/src/wayland/plasmashell_interface.h index 8daf08626e..ee82ecdb9f 100644 --- a/src/wayland/plasmashell_interface.h +++ b/src/wayland/plasmashell_interface.h @@ -168,13 +168,14 @@ public: void showAutoHidingPanel(); /** - * Whether a PlasmaShellSurfaceInterface with Role Panel wants to have focus. + * Whether a PlasmaShellSurfaceInterface wants to have focus. * - * By default a Panel does not get focus, but the PlasmaShellSurfaceInterface can + * By default some PlasmaShell roles do not get focus, but the PlasmaShellSurfaceInterface can * request that it wants to have focus. The compositor can use this information to - * pass focus to the panel. + * pass focus to the surface. * @since 5.28 **/ + //TODO KF6 rename to something generic bool panelTakesFocus() const; /**