From 69feba45ee7732fd9c90666d99a0bfcac00a3e73 Mon Sep 17 00:00:00 2001 From: ivan tkachenko Date: Fri, 2 Jun 2023 19:47:08 +0300 Subject: [PATCH] kcms/rules: Port signal handlers to explicit arguments, fix QML/JS code style Implicit injection of arguments is deprecated in Qt 6, and throws runtime warnings. --- src/kcms/rules/package/contents/ui/main.qml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/kcms/rules/package/contents/ui/main.qml b/src/kcms/rules/package/contents/ui/main.qml index 5955bef9b0..a08fd15641 100644 --- a/src/kcms/rules/package/contents/ui/main.qml +++ b/src/kcms/rules/package/contents/ui/main.qml @@ -50,7 +50,10 @@ KCM.ScrollViewKCM { highlightMoveDuration: Kirigami.Units.longDuration displaced: Transition { - NumberAnimation { properties: "y"; duration: Kirigami.Units.longDuration } + NumberAnimation { + properties: "y" + duration: Kirigami.Units.longDuration + } } Kirigami.PlaceholderMessage { @@ -120,7 +123,7 @@ KCM.ScrollViewKCM { checkable: true checked: exportInfo.visible onToggled: { - selectedIndexes = [] + selectedIndexes = []; exportInfo.visible = checked; } } @@ -128,8 +131,8 @@ KCM.ScrollViewKCM { component RuleBookDelegate : Item { // External item required to make Kirigami.ListItemDragHandle work - width : ruleBookView.width - implicitHeight : ruleBookItem.implicitHeight + width: ruleBookView.width + implicitHeight: ruleBookItem.implicitHeight ListView.onPooled: { if (descriptionField.activeFocus) { @@ -146,7 +149,7 @@ KCM.ScrollViewKCM { visible: !exportInfo.visible listItem: ruleBookItem listView: ruleBookView - onMoveRequested: { + onMoveRequested: (oldIndex, newIndex) => { kcm.moveRule(oldIndex, newIndex); } } @@ -161,7 +164,7 @@ KCM.ScrollViewKCM { onEditingFinished: { kcm.setRuleDescription(index, text); } - Keys.onPressed: { + Keys.onPressed: event => { switch (event.key) { case Qt.Key_Escape: // On key reset to model data before losing focus