yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only send OutputConfig sendApplied / sendFailed to the right resource

Browse source 
Summary:
I don't understand the original logic.
s_allResources contains /every/ resource, not just outputconfigurations.

Sending org_kde_kwin_outputconfiguration_send_applied to a wl_surface (for example),
results in an error.

The reason kwin doesn't currently crash is because we don't actually send
applied/failed after setting outputs. (which is another bug)

Test Plan: The existing unit test still passes.

Reviewers: #plasma, sebas

Reviewed By: #plasma, sebas

Subscribers: sebas, plasma-devel, #frameworks

Tags: #plasma_on_wayland, #frameworks

Differential Revision: https://phabricator.kde.org/D7898
This commit is contained in:
David Edmundson 2017-09-21 14:11:30 +01:00
parent a1cfc8a5f3
commit 6b460f9a7f
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/wayland/server/outputconfiguration_interface.cpp
View file

@ -227,9 +227,7 @@ void OutputConfigurationInterface::setApplied()
void OutputConfigurationInterface::Private::sendApplied() void OutputConfigurationInterface::Private::sendApplied()
{ {
for (const auto &r: s_allResources) { org_kde_kwin_outputconfiguration_send_applied(resource);
org_kde_kwin_outputconfiguration_send_applied(r->resource);
}
} }
void OutputConfigurationInterface::setFailed() void OutputConfigurationInterface::setFailed()
@ -241,9 +239,7 @@ void OutputConfigurationInterface::setFailed()
void OutputConfigurationInterface::Private::sendFailed() void OutputConfigurationInterface::Private::sendFailed()
{ {
for (const auto &r: s_allResources) { org_kde_kwin_outputconfiguration_send_failed(resource);
org_kde_kwin_outputconfiguration_send_failed(r->resource);
}
} }
OutputChangeSet* OutputConfigurationInterface::Private::pendingChanges(OutputDeviceInterface *outputdevice) OutputChangeSet* OutputConfigurationInterface::Private::pendingChanges(OutputDeviceInterface *outputdevice)