yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[autotests] Hopefully stabilise TestShellClient

Browse source 
Summary:
Apparently this test is flaky, based on the output I recieved we had
processed the un-fullscreen but not the un-maximise.

It seems possible the wayland thread could process when there's only one
request in the queue.

Test Plan:
Couldn't reproduce the original issue, it's a blind patch but the
current tests still pass.

Reviewers: #kwin

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16955
This commit is contained in:
David Edmundson 2018-11-17 12:06:35 +00:00
parent 01b75b39bb
commit 6c71403281
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
autotests/integration/shell_client_test.cpp
View file

@ -730,7 +730,10 @@ void TestShellClient::testMaximizedToFullscreen()
QVERIFY(fullscreenChangedSpy.wait()); QVERIFY(fullscreenChangedSpy.wait());
if (decoMode == ServerSideDecoration::Mode::Server) { if (decoMode == ServerSideDecoration::Mode::Server) {
QVERIFY(sizeChangeRequestedSpy.wait()); QVERIFY(sizeChangeRequestedSpy.wait());
// don't check count, XDG might legitimately get two updates // XDG will legitimately get two updates. They might be batched
if (xdgShellSurface && sizeChangeRequestedSpy.count() == 1) {
QVERIFY(sizeChangeRequestedSpy.wait());
}
// fails as we don't correctly call setMaximize(false) // fails as we don't correctly call setMaximize(false)
// but realistically the only toolkits that support the deco also use XDGShell // but realistically the only toolkits that support the deco also use XDGShell