yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Hardcode TabBox setting in boxswitch effect false

Browse source 
Boxswitch is activated as tabbox, possibly due to a downstream issue
This results in multiple effects being assigned to the tabbox and no
GUI way for the user to fix this.
Since the BoxSwitch effects nowadays only exists  as sidearm for
coverswitch, the tabbox setting is now hardcoded and disabled in the
effect, making it completely impossible to accidentally use it as tabbox.

BUG: 303387
REVIEW: 106695
FIXED-IN: 4.9.3
This commit is contained in:
Thomas Lübking 2012-10-03 18:57:00 +02:00
parent dbf2623e87
commit 6cba742315
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
effects/boxswitch/boxswitch.cpp
View file

@ -42,7 +42,7 @@ BoxSwitchEffect::BoxSwitchEffect()
, painting_desktop(0) , painting_desktop(0)
, animation(false) , animation(false)
, highlight_is_set(false) , highlight_is_set(false)
, primaryTabBox(true) , primaryTabBox(false)
, secondaryTabBox(false) , secondaryTabBox(false)
, mProxy(this) , mProxy(this)
, mProxyActivated(0) , mProxyActivated(0)
@ -86,8 +86,9 @@ void BoxSwitchEffect::reconfigure(ReconfigureFlags)
elevate_window = conf.readEntry("ElevateSelected", true); elevate_window = conf.readEntry("ElevateSelected", true);
mAnimateSwitch = conf.readEntry("AnimateSwitch", false); mAnimateSwitch = conf.readEntry("AnimateSwitch", false);
primaryTabBox = conf.readEntry("TabBox", false); // the tabbox merely exists as CoverSwitch sidearm, force it to be not the tabbox
secondaryTabBox = conf.readEntry("TabBoxAlternative", false); primaryTabBox = false;
secondaryTabBox = false;
} }
void BoxSwitchEffect::prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time) void BoxSwitchEffect::prePaintWindow(EffectWindow* w, WindowPrePaintData& data, int time)