From 6d37ce7f363d7f22be00f0fb301957c172488137 Mon Sep 17 00:00:00 2001 From: Aleix Pol Date: Wed, 20 Mar 2019 17:36:56 +0100 Subject: [PATCH] RFC: Fix wayland backend initialisation Summary: Otherwise it thinks outputs couldn't be created and it leaves. Problem is that after this fix it crashes when it actually does things with: kwin_wayland: /home/apol/devel/frameworks/kwin/composite.cpp:646: void KWin::Compositor::aboutToSwapBuffers(): Assertion `!m_bufferSwapPending' failed. Test Plan: As said, it proceeds correctly and crashes elsewhere Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: davidedmundson, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D19921 --- plugins/platforms/wayland/egl_wayland_backend.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/platforms/wayland/egl_wayland_backend.cpp b/plugins/platforms/wayland/egl_wayland_backend.cpp index 67532178a8..9113a96f33 100644 --- a/plugins/platforms/wayland/egl_wayland_backend.cpp +++ b/plugins/platforms/wayland/egl_wayland_backend.cpp @@ -137,7 +137,7 @@ void EglWaylandBackend::cleanupSurfaces() bool EglWaylandBackend::createEglWaylandOutput(WaylandOutput *waylandOutput) { auto *output = new EglWaylandOutput(waylandOutput, this); - if (output->init(this)) { + if (!output->init(this)) { return false; } m_outputs << output;