yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gbm_dmabuf: Fix crash if gbm_bo_create fails

Browse source 
And perform proper cleanup if eglCreateImageKHR fails.
This commit is contained in:
Fabian Vogt 2021-09-22 22:53:51 +02:00 committed by Vlad Zahorodnii
parent c94c2128bd
commit 6e1564fc17
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/plugins/platforms/drm/gbm_dmabuf.cpp
View file

@ -38,7 +38,6 @@ KWin::GbmDmaBuf *GbmDmaBuf::createBuffer(const QSize &size, gbm_device *device)
auto bo = gbm_bo_create(device, size.width(), size.height(), GBM_FORMAT_ARGB8888, GBM_BO_USE_RENDERING | GBM_BO_USE_LINEAR);
if (!bo) {
gbm_bo_destroy(bo);
return nullptr;
}
@ -61,6 +60,8 @@ KWin::GbmDmaBuf *GbmDmaBuf::createBuffer(const QSize &size, gbm_device *device)
EGLDisplay display = kwinApp()->platform()->sceneEglDisplay();
EGLImageKHR destinationImage = eglCreateImageKHR(display, EGL_NO_CONTEXT, EGL_LINUX_DMA_BUF_EXT, nullptr, importAttributes);
if (destinationImage == EGL_NO_IMAGE_KHR) {
close(fd);
gbm_bo_destroy(bo);
return nullptr;
}