From 6f173fc609c94343c1f737446c57aded63974f98 Mon Sep 17 00:00:00 2001
From: Vlad Zagorodniy <vladzzag@gmail.com>
Date: Sun, 1 Jul 2018 10:30:30 +0300
Subject: [PATCH] Use QHash::value() in EffectWindowImpl::data()

Summary:
The `role` hash key is hashed twice:
* first, when calling `contains` method;
* second, when using `operator[]`.

We can do better by using [QHash::value](http://doc.qt.io/qt-5/qhash.html#value).

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: pino, davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13820
---
 effects.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/effects.cpp b/effects.cpp
index c845b985b2..d48b9a2394 100644
--- a/effects.cpp
+++ b/effects.cpp
@@ -1736,9 +1736,7 @@ void EffectWindowImpl::setData(int role, const QVariant &data)
 
 QVariant EffectWindowImpl::data(int role) const
 {
-    if (!dataMap.contains(role))
-        return QVariant();
-    return dataMap[ role ];
+    return dataMap.value(role);
 }
 
 EffectWindow* effectWindow(Toplevel* w)