yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Effectsmodel: Load KCM by path instead of searching for plugin by id

Browse source 
This way we do not need to embed json metadata in the plugins
and can consequently drop the metadata files entirely.

The resulting metadata object might still be invalid, however KCoreAddons
can handle such cases. See https://phabricator.kde.org/T15094 regarding
create better KCoreAddons API for such cases.
This commit is contained in:
Alexander Lohnau 2021-12-21 15:39:09 +01:00
parent c59c52cb0c
commit 728b449891
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/kcmkwin/common/effectsmodel.cpp
View file

@ -623,12 +623,11 @@ QModelIndex EffectsModel::findByPluginId(const QString &pluginId) const
static KCModule *loadBinaryConfig(const QString &configModule, QObject *parent)
{
const KPluginMetaData metaData = KPluginMetaData::findPluginById(QStringLiteral("kwin/effects/configs/"), configModule);
if (!metaData.isValid()) {
if (configModule.isEmpty()) {
return nullptr;
}
const KPluginMetaData metaData(QStringLiteral("kwin/effects/configs/") + configModule);
return KPluginFactory::instantiatePlugin<KCModule>(metaData, parent).plugin;
}