yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DesktopGridEffect: Fix crash when closing the effect

Browse source 
If the first condition would match (for instance after moving a window),
`windowMove` would be `nullptr`, triggering the crash later.

By the looks of it, it was maybe a typo.

BUG: 445335
FIXED-IN: 5.24

CC: @nicolasfella
This commit is contained in:
Ismael Asensio 2022-01-07 21:16:04 +00:00
parent d13c39bec6
commit 72c0974a06
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/effects/desktopgrid/desktopgrid.cpp
View file

@ -445,7 +445,7 @@ void DesktopGridEffect::slotWindowClosed(EffectWindow* w)
windowMove = nullptr; windowMove = nullptr;
} }
if (isUsingPresentWindows()) { if (isUsingPresentWindows()) {
const auto desktops = desktopList(windowMove); const auto desktops = desktopList(w);
for (const int i : desktops) { for (const int i : desktops) {
WindowMotionManager& manager = m_managers[w->screen()][i]; WindowMotionManager& manager = m_managers[w->screen()][i];
manager.unmanage(w); manager.unmanage(w);