From 74af27dc559c894b691e6cd452385b5459437372 Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Thu, 15 Sep 2022 23:18:41 +0300 Subject: [PATCH] Add missing QPointer The Compositor is destroyed after the Workspace, so the placeholder has shorter lifespan. We need to guard the destructor of EffectScreenImpl from accessing a dangling pointer. For what it's worth, the destructor of EffectScreenImpl was written with QPointer in mind, but it was never added. --- src/effects.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/effects.h b/src/effects.h index 69b5628c67..4fab5337d7 100644 --- a/src/effects.h +++ b/src/effects.h @@ -374,7 +374,7 @@ public: static EffectScreenImpl *get(Output *output); private: - Output *m_platformOutput; + QPointer m_platformOutput; }; class EffectWindowImpl : public EffectWindow