From 75456580e5618aba30176693e12855f21579878e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Sun, 29 Aug 2010 08:44:32 +0000 Subject: [PATCH] Forward port rev 1169432: Fix window movment regression (e.g. pack) in 4.5. The regression was caused in tiling which set the geometry to a different one again. Nikhil please verify that tiling is still working correctly. Looking at the code this commit should be side-effect free. When coming from Client::move() moveResizeGeom and initialMoveResizeGeom may not be set. So I think the code in notifyTilingWindowMove() cannot work at all ;-) CCBUG: 241049 svn path=/trunk/KDE/kdebase/workspace/; revision=1169433 --- tiling.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/tiling.cpp b/tiling.cpp index 4abce34b90..4001b2e16a 100644 --- a/tiling.cpp +++ b/tiling.cpp @@ -175,7 +175,6 @@ void Workspace::notifyTilingWindowMove( Client *c, const QRect &moveResizeGeom, { if( tilingLayouts.value( c->desktop() ) == NULL ) { - c->setGeometry( moveResizeGeom ); return; } tilingLayouts[ c->desktop() ]->clientMoved( c, moveResizeGeom, orig );