From 75cd7922df6a2f58b017f05214866fc0cafcdaf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Fri, 6 Jun 2008 09:20:01 +0000 Subject: [PATCH] Draw shadow for popups even if they have shape, they should be almost rectangular anyway, so this is a workaround as long as there's no support for shadows for shaped windows. BUG: 162697 svn path=/trunk/KDE/kdebase/workspace/; revision=817551 --- effects/shadow.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/effects/shadow.cpp b/effects/shadow.cpp index 923a8c2519..a9eb5ee94c 100644 --- a/effects/shadow.cpp +++ b/effects/shadow.cpp @@ -142,7 +142,9 @@ void ShadowEffect::windowClosed( EffectWindow* c ) bool ShadowEffect::useShadow( EffectWindow* w ) const { - return !w->isDeleted() && !w->isDesktop() && !w->isDock() && !w->hasOwnShape(); + return !w->isDeleted() && !w->isDesktop() && !w->isDock() + // popups may have shadow even if shaped, their shape is almost rectangular + && ( !w->hasOwnShape() || w->isDropdownMenu() || w->isPopupMenu() || w->isComboBox()); } void ShadowEffect::addQuadVertices(QVector& verts, float x1, float y1, float x2, float y2) const