yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[autotests/integration] Make MoveResizeWindowTest more robust

Browse source 
A few more cases where we need to ensure that the created window is
destroyed before going into next test method.

Interesting observation: the generated window ids are identical.
Possible problem with KWayland::ClientConnection?
This commit is contained in:
Martin Gräßlin 2016-07-01 15:21:37 +02:00
parent ce74d8a5e5
commit 7610ff49a8
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
autotests/integration/move_resize_window_test.cpp
View file

@ -399,6 +399,8 @@ void MoveResizeWindowTest::testPointerMoveEnd()
// but releasing the other button should now end moving // but releasing the other button should now end moving
kwinApp()->platform()->pointerButtonReleased(additionalButton, timestamp++); kwinApp()->platform()->pointerButtonReleased(additionalButton, timestamp++);
QVERIFY(!c->isMove()); QVERIFY(!c->isMove());
surface.reset();
QVERIFY(Test::waitForWindowDestroyed(c));
} }
void MoveResizeWindowTest::testPlasmaShellSurfaceMovable_data() void MoveResizeWindowTest::testPlasmaShellSurfaceMovable_data()
@ -435,6 +437,8 @@ void MoveResizeWindowTest::testPlasmaShellSurfaceMovable()
QTEST(c->isMovable(), "movable"); QTEST(c->isMovable(), "movable");
QTEST(c->isMovableAcrossScreens(), "movableAcrossScreens"); QTEST(c->isMovableAcrossScreens(), "movableAcrossScreens");
QTEST(c->isResizable(), "resizable"); QTEST(c->isResizable(), "resizable");
surface.reset();
QVERIFY(Test::waitForWindowDestroyed(c));
} }
void MoveResizeWindowTest::testNetMove() void MoveResizeWindowTest::testNetMove()
@ -484,6 +488,7 @@ void MoveResizeWindowTest::testNetMove()
QVERIFY(moveEndSpy.isValid()); QVERIFY(moveEndSpy.isValid());
QSignalSpy moveStepSpy(client, &Client::clientStepUserMovedResized); QSignalSpy moveStepSpy(client, &Client::clientStepUserMovedResized);
QVERIFY(moveStepSpy.isValid()); QVERIFY(moveStepSpy.isValid());
QVERIFY(!workspace()->getMovingClient());
// use NETRootInfo to trigger a move request // use NETRootInfo to trigger a move request
NETRootInfo root(c.data(), NET::Properties()); NETRootInfo root(c.data(), NET::Properties());