From 77affd325923742e611c4a0e2c0c124fc9e6a7f5 Mon Sep 17 00:00:00 2001 From: Nate Graham Date: Tue, 15 Jun 2021 17:24:26 -0600 Subject: [PATCH] [kcmkwin/kwindesktop] Drop local back for Formlayout label width This hack was added in the past to prevent the combobox from being pushed out of view when the label next to it was very long, as it can be in certain languages. However it had the effect of making the label get elided in *all* languages, and also the issue it was working around is no longer present; even with very long text, the combobox no longer gets pushed out of view, and instead the formlayout first switches to mobile view and then elides the Label, exactly as intended. So we can safely remove the hack. BUG: 438504 FIXED-IN: 5.22.2 --- src/kcmkwin/kwindesktop/package/contents/ui/main.qml | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/kcmkwin/kwindesktop/package/contents/ui/main.qml b/src/kcmkwin/kwindesktop/package/contents/ui/main.qml index 1d72a59c19..08bce838f9 100644 --- a/src/kcmkwin/kwindesktop/package/contents/ui/main.qml +++ b/src/kcmkwin/kwindesktop/package/contents/ui/main.qml @@ -213,9 +213,7 @@ KCM.ScrollViewKCM { QQC2.CheckBox { id: animationEnabled - // Let it elide but don't make it push the ComboBox away from it Layout.fillWidth: true - Layout.maximumWidth: implicitWidth text: i18n("Show animation when switching:")