yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugins/nightlight: Guard against invalid timings in the config

Browse source 
Morning and evening timings should be ordered correctly. When computing
the daylight duration, that ternary operator should not be needed and it
hides other bugs.
This commit is contained in:
Vlad Zahorodnii 2024-06-14 18:00:53 +03:00
parent 07f266e7c7
commit 786b3ffbae
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/plugins/nightlight/nightlightmanager.cpp
View file

@ -279,8 +279,12 @@ void NightLightManager::readConfig()
// fixed timings
QTime mrB = QTime::fromString(s->morningBeginFixed(), "hhmm");
QTime evB = QTime::fromString(s->eveningBeginFixed(), "hhmm");
if (mrB >= evB) {
mrB = QTime(6, 0);
evB = QTime(18, 0);
}
int diffME = evB > mrB ? mrB.msecsTo(evB) : evB.msecsTo(mrB);
int diffME = mrB.msecsTo(evB);
int diffMin = std::min(diffME, MSC_DAY - diffME);
int trTime = s->transitionTime() * 1000 * 60;