From 7c15bc7765eb1087c2e6f23854549f6908a2d9b5 Mon Sep 17 00:00:00 2001 From: David Edmundson Date: Tue, 15 Jan 2019 21:52:28 +0000 Subject: [PATCH] [kcmkwin/kwindesktop] Fix error in desktop layout indicator initial state Summary: kcm.osdTextOnly is the inverse of "show desktop layout indicators" The save was inversed, the load was not. Also port from onCheckedChanged to onToggled as that's emitted only on user changes and not on binding re-evaluation. BUG: 403150 Test Plan: Toggled it Reopened KCM Checked kwinrc Reviewers: #kwin, ngraham Reviewed By: ngraham Subscribers: ngraham, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D18272 --- kcmkwin/kwindesktop/package/contents/ui/main.qml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kcmkwin/kwindesktop/package/contents/ui/main.qml b/kcmkwin/kwindesktop/package/contents/ui/main.qml index e7641247d3..55b066bb09 100644 --- a/kcmkwin/kwindesktop/package/contents/ui/main.qml +++ b/kcmkwin/kwindesktop/package/contents/ui/main.qml @@ -253,7 +253,7 @@ ScrollViewKCM { checked: kcm.osdEnabled - onCheckedChanged: kcm.osdEnabled = checked + onToggled: kcm.osdEnabled = checked } QtControls.SpinBox { @@ -287,9 +287,9 @@ ScrollViewKCM { text: i18n("Show desktop layout indicators") - checked: kcm.osdTextOnly + checked: !kcm.osdTextOnly - onCheckedChanged: kcm.osdTextOnly = !checked + onToggled: kcm.osdTextOnly = !checked } } }