Remove unneeded includes from headers and cpp files

data/update_default_rules.cpp

@@ -9,11 +9,13 @@
 
 // read additional window rules and add them to kwinrulesrc
 
+#include <KConfig>
+#include <KConfigGroup>
+#include <QCoreApplication>
+#include <QDBusConnection>
+#include <QDBusMessage>
 #include <QDebug>
 #include <QStandardPaths>
-#include <QtDBus>
-#include <kconfig.h>
-#include <kconfiggroup.h>
 
 int main(int argc, char *argv[])
 {

src/activities.h

@@ -8,10 +8,9 @@
 */
 #pragma once
 
-#include "effect/globals.h"
-
 #include <QObject>
 #include <QStringList>
+#include <kwin_export.h>
 
 #include <PlasmaActivities/Controller>
 

src/appmenu.h

@@ -9,8 +9,6 @@
     SPDX-License-Identifier: GPL-2.0-or-later
 */
 #pragma once
-// KWin
-#include "effect/globals.h"
 // Qt
 #include <QObject>
 // xcb

src/backends/drm/drm_abstract_output.cpp

@@ -8,7 +8,6 @@
 */
 #include "drm_abstract_output.h"
 #include "core/renderbackend.h"
-#include "core/renderloop_p.h"
 #include "drm_backend.h"
 #include "drm_gpu.h"
 #include "drm_layer.h"

src/backends/drm/drm_buffer.cpp

@@ -11,7 +11,6 @@
 
 #include "core/graphicsbuffer.h"
 #include "drm_gpu.h"
-#include "drm_logging.h"
 
 // system
 #include <sys/mman.h>
@@ -19,8 +18,6 @@
 #include <linux/dma-buf.h>
 #include <linux/sync_file.h>
 #endif
-// c++
-#include <cerrno>
 // drm
 #include <drm_fourcc.h>
 #include <sys/ioctl.h>

src/backends/drm/drm_crtc.cpp

@@ -11,10 +11,8 @@
 #include "drm_buffer.h"
 #include "drm_commit.h"
 #include "drm_gpu.h"
-#include "drm_logging.h"
 #include "drm_output.h"
 #include "drm_pointer.h"
-#include <cerrno>
 
 namespace KWin
 {

src/backends/drm/drm_egl_backend.cpp

@@ -18,10 +18,8 @@
 #include "drm_output.h"
 #include "drm_pipeline.h"
 #include "drm_virtual_egl_layer.h"
-#include "opengl/eglutils_p.h"
 // system
 #include <drm_fourcc.h>
-#include <errno.h>
 #include <gbm.h>
 #include <unistd.h>
 

src/backends/drm/icc_shader.cpp

@@ -11,7 +11,6 @@
 #include "opengl/gllut3D.h"
 #include "opengl/glshader.h"
 #include "opengl/glshadermanager.h"
-#include "opengl/gltexture.h"
 
 namespace KWin
 {

src/compositor.h

@@ -9,9 +9,10 @@
 */
 #pragma once
 
-#include "effect/globals.h"
+#include <kwin_export.h>
 #include <xcb/xcb.h>
 
+#include <QHash>
 #include <QObject>
 #include <QRegion>
 #include <QTimer>

src/compositor_wayland.h

@@ -11,6 +11,7 @@
 #pragma once
 
 #include "compositor.h"
+#include "effect/globals.h"
 
 namespace KWin
 {

src/compositor_x11.h

@@ -11,6 +11,7 @@
 #pragma once
 
 #include "compositor.h"
+#include <QSet>
 
 namespace KWin
 {

src/decorations/decorationbridge.h

@@ -8,14 +8,11 @@
 */
 #pragma once
 
-#include "effect/globals.h"
-
+#include "kwin_export.h"
 #include <KDecoration2/Private/DecorationBridge>
-
 #include <QObject>
 
 class KPluginFactory;
-
 namespace KDecoration2
 {
 class DecorationSettings;

src/decorations/decorationpalette.cpp

@@ -11,7 +11,6 @@
 */
 
 #include "decorationpalette.h"
-#include "decorations_logging.h"
 
 #include <KConfigGroup>
 

src/effect/anidata.cpp

@@ -11,8 +11,6 @@
 #include "effect/anidata_p.h"
 #include "effect/effecthandler.h"
 
-#include "logging_p.h"
-
 namespace KWin
 {
 

src/effect/animationeffect.cpp

@@ -11,7 +11,8 @@
 #include "effect/animationeffect.h"
 #include "effect/anidata_p.h"
 #include "effect/effecthandler.h"
-#include "opengl/glutils.h"
+#include "opengl/glshader.h"
+#include "opengl/glshadermanager.h"
 
 #include <QDateTime>
 #include <QTimer>

src/effect/effecthandler.cpp

@@ -16,7 +16,6 @@
 #include "compositor.h"
 #include "core/output.h"
 #include "core/renderbackend.h"
-#include "core/renderlayer.h"
 #include "core/rendertarget.h"
 #include "core/renderviewport.h"
 #include "decorations/decorationbridge.h"
@@ -28,7 +27,9 @@
 #include "inputmethod.h"
 #include "inputpanelv1window.h"
 #include "keyboard_input.h"
-#include "opengl/glutils.h"
+#include "opengl/glshader.h"
+#include "opengl/glshadermanager.h"
+#include "opengl/gltexture.h"
 #include "osd.h"
 #include "pointer_input.h"
 #include "scene/itemrenderer.h"
@@ -65,8 +66,6 @@
 #include <QWindow>
 #include <QtMath>
 
-#include <optional>
-
 namespace KWin
 {
 

src/effect/effecthandler.h

@@ -29,11 +29,7 @@
 
 #include <netwm.h>
 
-#include <climits>
-#include <cmath>
 #include <functional>
-#include <optional>
-#include <span>
 
 class KConfigGroup;
 class QFont;

src/kcms/compositing/kwincompositingdata.h

@@ -11,7 +11,7 @@
 
 #include <QObject>
 
-#include "kcmoduledata.h"
+#include <KCModuleData>
 
 class KWinCompositingSetting;
 

src/kcms/decoration/decorationmodel.cpp

@@ -4,6 +4,7 @@
     SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
 */
 #include "decorationmodel.h"
+#include "utils.h"
 // KDecoration2
 #include <KDecoration2/Decoration>
 #include <KDecoration2/DecorationSettings>

src/kcms/decoration/decorationmodel.h

@@ -5,8 +5,6 @@
 */
 #pragma once
 
-#include "utils.h"
-
 #include <KDecoration2/DecorationThemeProvider>
 #include <QAbstractListModel>
 

src/kcms/decoration/kcm.cpp

@@ -24,6 +24,7 @@
 
 #include "kwindecorationdata.h"
 #include "kwindecorationsettings.h"
+#include "utils.h"
 
 K_PLUGIN_FACTORY_WITH_JSON(KCMKWinDecorationFactory, "kcm_kwindecoration.json", registerPlugin<KCMKWinDecoration>(); registerPlugin<KWinDecorationData>();)
 

src/kcms/decoration/kcm.h

@@ -7,8 +7,6 @@
 
 #pragma once
 
-#include "utils.h"
-
 #include <KQuickManagedConfigModule>
 #include <QAbstractListModel>
 

src/kcms/options/mouse.cpp

@@ -5,13 +5,11 @@
 */
 
 #include "mouse.h"
-
-#include <QtDBus>
-
-#include <cstdlib>
-
 #include "kwinoptions_settings.h"
 
+#include <QDBusConnection>
+#include <QDBusMessage>
+
 KWinMouseConfigForm::KWinMouseConfigForm(QWidget *parent)
     : QWidget(parent)
 {

src/kcms/scripts/module.cpp

@@ -20,7 +20,6 @@
 #include <KPackage/PackageLoader>
 #include <KSharedConfig>
 
-#include "config-kwin.h"
 #include "kwinscriptsdata.h"
 
 Module::Module(QObject *parent, const KPluginMetaData &data)

src/kcms/tabbox/main.cpp

@@ -36,7 +36,6 @@
 
 // own
 #include "kwinpluginssettings.h"
-#include "kwinswitcheffectsettings.h"
 #include "kwintabboxconfigform.h"
 #include "kwintabboxdata.h"
 #include "kwintabboxsettings.h"

src/kcms/tabbox/main.h

@@ -11,7 +11,6 @@
 
 #pragma once
 
-#include "tabbox/tabboxconfig.h"
 #include <kcmodule.h>
 #include <ksharedconfig.h>
 

src/scripting/scriptedeffect.cpp

@@ -9,8 +9,9 @@
 */
 
 #include "scriptedeffect.h"
+#include "opengl/glshader.h"
+#include "opengl/glshadermanager.h"
 #include "scripting_logging.h"
-#include "scriptingutils.h"
 #include "workspace_wrapper.h"
 
 #include "core/output.h"
@@ -19,7 +20,6 @@
 #include "screenedge.h"
 #include "workspace.h"
 // KDE
-#include "opengl/glutils.h"
 #include <KConfigGroup>
 #include <KGlobalAccel>
 #include <KPluginMetaData>

src/scripting/tilemodel.cpp

@@ -8,9 +8,7 @@
 */
 
 #include "tilemodel.h"
-#include "core/output.h"
 #include "tiles/tilemanager.h"
-#include "virtualdesktops.h"
 #include "workspace.h"
 
 #include <KConfigGroup>

src/scripting/tilemodel.h

@@ -10,9 +10,7 @@
 #pragma once
 
 #include "tiles/customtile.h"
-#include "tiles/quicktile.h"
 #include "tiles/tile.h"
-#include "utils/common.h"
 #include <kwin_export.h>
 
 #include <QAbstractItemModel>

src/scripting/windowthumbnailitem.cpp

@@ -12,16 +12,15 @@
 #include "core/rendertarget.h"
 #include "core/renderviewport.h"
 #include "effect/effect.h"
+#include "opengl/glframebuffer.h"
 #include "scene/itemrenderer.h"
 #include "scene/windowitem.h"
 #include "scene/workspacescene.h"
 #include "scripting_logging.h"
-#include "virtualdesktops.h"
 #include "window.h"
 #include "workspace.h"
 
 #include "opengl/gltexture.h"
-#include "opengl/glutils.h"
 
 #include <QQuickWindow>
 #include <QRunnable>
@@ -350,6 +349,7 @@ void WindowThumbnailItem::setWId(const QUuid &wId)
         updateImplicitSize();
         Q_EMIT clientChanged();
     }
+
     Q_EMIT wIdChanged();
 }