From 7db140d03be1a518f783378b6cee1ae45fc5a038 Mon Sep 17 00:00:00 2001 From: ivan tkachenko Date: Sat, 3 Jun 2023 17:30:19 +0300 Subject: [PATCH] kcms/effects: Move footer actions to the page header MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …to avoid the "two stacked rows of buttons" effect. Changes "Get New" button text to avoid redundancy because title already contains the "Desktop Effects" string in it. --- src/kcms/effects/package/contents/ui/main.qml | 28 ++++++++----------- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/src/kcms/effects/package/contents/ui/main.qml b/src/kcms/effects/package/contents/ui/main.qml index 52d9448b57..ee60c2b746 100644 --- a/src/kcms/effects/package/contents/ui/main.qml +++ b/src/kcms/effects/package/contents/ui/main.qml @@ -20,6 +20,17 @@ ScrollViewKCM { implicitHeight: Kirigami.Units.gridUnit * 30 implicitWidth: Kirigami.Units.gridUnit * 40 + actions: NewStuff.Action { + text: i18n("Get New…") + visible: KAuthorized.authorize(KAuthorized.GHNS) + configFile: "kwineffect.knsrc" + onEntryEvent: (entry, event) => { + if (event === NewStuff.Engine.StatusChangedEvent) { + kcm.onGHNSEntriesChanged() + } + } + } + header: ColumnLayout { spacing: Kirigami.Units.smallSpacing @@ -119,21 +130,4 @@ ScrollViewKCM { return group; } } - - footer: ColumnLayout { - RowLayout { - Layout.alignment: Qt.AlignRight - - NewStuff.Button { - text: i18n("Get New Desktop Effects…") - visible: KAuthorized.authorize(KAuthorized.GHNS) - configFile: "kwineffect.knsrc" - onEntryEvent: (entry, event) => { - if (event === NewStuff.Engine.StatusChangedEvent) { - kcm.onGHNSEntriesChanged() - } - } - } - } - } }