yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Drop Window::addWorkspaceRepaint

Browse source 
It's used only by window elevation logic, but it can be moved inside
libkwineffects. It should also fix missing repainting in scripted effects.
This commit is contained in:
Vlad Zahorodnii 2023-02-22 12:47:58 +02:00
parent 911138f9db
commit 7f4071c7d4
3 changed files with 1 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/effects.cpp
View file

@ -1143,6 +1143,7 @@ void EffectsHandlerImpl::setElevatedWindow(KWin::EffectWindow *w, bool set)
if (set) {
elevated_windows.append(w);
}
addRepaint(w->expandedGeometry());
}
void EffectsHandlerImpl::setTabBoxWindow(EffectWindow *w)

20
src/window.cpp
View file

@ -369,25 +369,6 @@ void Window::finishCompositing(ReleaseReason releaseReason)
m_windowItem.reset();
}
void Window::addWorkspaceRepaint(int x, int y, int w, int h)
{
addWorkspaceRepaint(QRectF(x, y, w, h));
}
void Window::addWorkspaceRepaint(const QRectF &r2)
{
if (Compositor::compositing()) {
Compositor::self()->scene()->addRepaint(r2.toAlignedRect());
}
}
void Window::addWorkspaceRepaint(const QRegion &region)
{
if (Compositor::compositing()) {
Compositor::self()->scene()->addRepaint(region);
}
}
void Window::setReadyForPainting()
{
if (!ready_for_painting) {
@ -543,7 +524,6 @@ void Window::elevate(bool elevate)
return;
}
effectWindow()->elevate(elevate);
addWorkspaceRepaint(visibleGeometry());
}
pid_t Window::pid() const

4
src/window.h
View file

@ -718,10 +718,6 @@ public:
bool hasAlpha() const;
virtual bool setupCompositing();
virtual void finishCompositing(ReleaseReason releaseReason = ReleaseReason::Release);
// these call workspace->addRepaint(), but first transform the damage if needed
void addWorkspaceRepaint(const QRectF &r);
void addWorkspaceRepaint(int x, int y, int w, int h);
void addWorkspaceRepaint(const QRegion &region);
EffectWindowImpl *effectWindow();
const EffectWindowImpl *effectWindow() const;
SurfaceItem *surfaceItem() const;