From 8729ff25c9dbb04cd15601823f46d069c32438d6 Mon Sep 17 00:00:00 2001 From: Bhushan Shah Date: Mon, 23 Oct 2017 13:41:32 +0530 Subject: [PATCH] [platforms/hwcomposer] Make createOutput a non-static method Summary: there is no need for createOutput to be static, make it non-static, this also fixes the build failure introduced in commit 02d3daf28a474d7d7a30af9afcd73e41fcd960f2. Test Plan: builds Reviewers: #kwin, graesslin, davidedmundson Reviewed By: davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D8430 --- plugins/platforms/hwcomposer/hwcomposer_backend.cpp | 4 +--- plugins/platforms/hwcomposer/hwcomposer_backend.h | 4 ++++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/plugins/platforms/hwcomposer/hwcomposer_backend.cpp b/plugins/platforms/hwcomposer/hwcomposer_backend.cpp index e72e9458de..d871568d88 100644 --- a/plugins/platforms/hwcomposer/hwcomposer_backend.cpp +++ b/plugins/platforms/hwcomposer/hwcomposer_backend.cpp @@ -27,14 +27,12 @@ along with this program. If not, see . #include "wayland_server.h" // KWayland #include -#include #include // Qt #include #include // hybris/android #include -#include #include // linux #include @@ -164,7 +162,7 @@ HwcomposerBackend::~HwcomposerBackend() } } -static KWayland::Server::OutputInterface *createOutput(hwc_composer_device_1_t *device) +KWayland::Server::OutputInterface* HwcomposerBackend::createOutput(hwc_composer_device_1_t *device) { uint32_t configs[5]; size_t numConfigs = 5; diff --git a/plugins/platforms/hwcomposer/hwcomposer_backend.h b/plugins/platforms/hwcomposer/hwcomposer_backend.h index f7012e843e..29ae5a5f8e 100644 --- a/plugins/platforms/hwcomposer/hwcomposer_backend.h +++ b/plugins/platforms/hwcomposer/hwcomposer_backend.h @@ -28,10 +28,13 @@ along with this program. If not, see . #include // libhybris +#include #include // needed as hwcomposer_window.h includes EGL which on non-arm includes Xlib #include +#include + typedef struct hwc_display_contents_1 hwc_display_contents_1_t; typedef struct hwc_layer_1 hwc_layer_1_t; typedef struct hwc_composer_device_1 hwc_composer_device_1_t; @@ -101,6 +104,7 @@ private Q_SLOTS: private: void initLights(); void toggleScreenBrightness(); + KWayland::Server::OutputInterface* createOutput(hwc_composer_device_1_t *device); QSize m_displaySize; hwc_composer_device_1_t *m_device = nullptr; light_device_t *m_lights = nullptr;