yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[scenes/xrender] Correctly render client-side decorated clients

Browse source 
Summary:
The buffer shape is in buffer-local coordinates and must be mapped to
window coordinates. After that, we are free to map it to the global screen
coordinates.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D25733
This commit is contained in:
Vlad Zahorodnii 2019-12-12 14:39:03 +02:00
parent a7e18789cb
commit 8ab727766a
2 changed files with 17 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
plugins/scenes/xrender/scene_xrender.cpp
View file

@ -387,6 +387,16 @@ QPoint SceneXrender::Window::mapToScreen(int mask, const WindowPaintData &data,
return pt;
}
QRect SceneXrender::Window::bufferToWindowRect(const QRect &rect) const
{
return rect.translated(bufferOffset());
}
QRegion SceneXrender::Window::bufferToWindowRegion(const QRegion &region) const
{
return region.translated(bufferOffset());
}
void SceneXrender::Window::prepareTempPixmap()
{
const QSize oldSize = temp_visibleRect.size();
@ -447,7 +457,7 @@ void SceneXrender::Window::performPaint(int mask, QRegion region, WindowPaintDat
filter = ImageFilterFast;
// do required transformations
const QRect wr = mapToScreen(mask, data, QRect(0, 0, width(), height()));
QRect cr = QRect(toplevel->clientPos(), toplevel->clientSize()); // Client rect (in the window)
QRect cr = QRect(toplevel->clientPos(), toplevel->clientSize()); // Content rect (in the buffer)
qreal xscale = 1;
qreal yscale = 1;
bool scaled = false;
@ -461,11 +471,11 @@ void SceneXrender::Window::performPaint(int mask, QRegion region, WindowPaintDat
transformed_shape = decorationRect;
if (toplevel->shape()) {
// "xeyes" + decoration
transformed_shape -= cr;
transformed_shape += bufferShape();
transformed_shape -= bufferToWindowRect(cr);
transformed_shape += bufferToWindowRegion(bufferShape());
}
} else {
transformed_shape = bufferShape();
transformed_shape = bufferToWindowRegion(bufferShape());
}
if (toplevel->shadow()) {
transformed_shape |= toplevel->shadow()->shadowRegion();
@ -624,7 +634,7 @@ void SceneXrender::Window::performPaint(int mask, QRegion region, WindowPaintDat
if (blitInTempPixmap) {
dr.translate(-temp_visibleRect.topLeft());
} else {
dr = mapToScreen(mask, data, dr); // Destination rect
dr = mapToScreen(mask, data, bufferToWindowRect(dr)); // Destination rect
if (scaled) {
cr.moveLeft(cr.x() * xscale);
cr.moveTop(cr.y() * yscale);

2
plugins/scenes/xrender/scene_xrender.h
View file

@ -201,6 +201,8 @@ protected:
private:
QRect mapToScreen(int mask, const WindowPaintData &data, const QRect &rect) const;
QPoint mapToScreen(int mask, const WindowPaintData &data, const QPoint &point) const;
QRect bufferToWindowRect(const QRect &rect) const;
QRegion bufferToWindowRegion(const QRegion &region) const;
void prepareTempPixmap();
void setPictureFilter(xcb_render_picture_t pic, ImageFilterType filter);
SceneXrender *m_scene;