From 8d004349172d85676152c3bd11fb2dc0a6cfb52f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= Date: Mon, 2 Feb 2004 14:15:31 +0000 Subject: [PATCH] Don't disallow fullscreening for windows that have maximum size set, way too many apps apparently think setting a maximum or fixed size and then requesting fullscreen is ok. CCMAIL: 73509-done@bugs.kde.org svn path=/trunk/kdebase/kwin/; revision=284486 --- geometry.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/geometry.cpp b/geometry.cpp index 1c437c7ffb..71fb25fbc2 100644 --- a/geometry.cpp +++ b/geometry.cpp @@ -1394,14 +1394,15 @@ void Client::resetMaximize() bool Client::isFullScreenable( bool fullscreen_hack ) const { - return isFullScreen() // necessary, because for fullscreen windows isMaximizable() returns false - || (( isNormalWindow() || isOverride()) - && ( isMaximizable() || fullscreen_hack )); + if( fullscreen_hack ) + return isNormalWindow() || isOverride(); + else // don't check size constrains - some apps request fullscreen despite requesting fixed size + return !isSpecialWindow(); // also better disallow only weird types to go fullscreen } bool Client::userCanSetFullScreen() const { - return isFullScreenable() && isNormalWindow() && fullscreen_mode != FullScreenHack; + return isNormalWindow() && fullscreen_mode != FullScreenHack && isMaximizable(); } void Client::setFullScreen( bool set, bool user )