yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

inputpanel: Compensate the 1px difference in height for panel position

Browse source 
It seems there is a 1px offset in the availableArea height, so compensate
by subtracting an extra pixel from the input panel height, to avoid a gap
below the panel.

Fixes https://invent.kde.org/teams/plasma-mobile/issues/-/issues/150
This commit is contained in:
Rodney Dawes 2022-07-12 13:23:01 -04:00
parent 64f811107e
commit 8d588f165c
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
autotests/integration/inputmethod_test.cpp
View file

@ -151,7 +151,7 @@ void InputMethodTest::testOpenClose()
Test::render(surface.data(), toplevelConfigureRequestedSpy.last().first().value<QSize>(), Qt::red);
QVERIFY(frameGeometryChangedSpy.wait());
QCOMPARE(window->frameGeometry().height(), 1024 - keyboardClient->inputGeometry().height());
QCOMPARE(window->frameGeometry().height() - 1, 1024 - keyboardClient->inputGeometry().height());
// Hide the keyboard
textInput->hideInputPanel();

4
src/inputpanelv1window.cpp
View file

@ -96,7 +96,9 @@ void KWin::InputPanelV1Window::reposition()
panelSize = panelSize.boundedTo(availableArea.size());
QRect geo(availableArea.bottomLeft() - QPoint{0, panelSize.height()}, panelSize);
// bottomLeft appears to be 1px off, so take an extra pixel off the
// input panel height, to even things back out
QRect geo(availableArea.bottomLeft() - QPoint{0, panelSize.height() - 1}, panelSize);
geo.translate((availableArea.width() - panelSize.width()) / 2, availableArea.height() - outputArea.height());
moveResize(geo);
} break;