From 8d847bd0ff9f492dc873421f5c7d96e22e83eb4a Mon Sep 17 00:00:00 2001 From: Marco Martin Date: Wed, 9 Oct 2019 13:56:55 +0200 Subject: [PATCH] don't allow to resize or move fullscreen windows Summary: add the same check of the Client class: if a window is fullscreen, is not movable nor resizable Test Plan: Doesn't have any visible regression over normal usage, this partially tackles a bug that can be seen in plasma mobile: if the placement is "maximizing", then asking windows to be shown as fullscreen has no effect and they will always be shown as a normal maximized window. this now doesn't happen anymore.. most of the times, as there must be some race condition as a concause of the problem Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24515 --- shell_client.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/shell_client.cpp b/shell_client.cpp index f08050363e..515c63d9b9 100644 --- a/shell_client.cpp +++ b/shell_client.cpp @@ -805,6 +805,9 @@ bool ShellClient::isMinimizable() const bool ShellClient::isMovable() const { + if (isFullScreen()) { + return false; + } if (rules()->checkPosition(invalidPoint) != invalidPoint) { return false; } @@ -833,6 +836,9 @@ bool ShellClient::isMovableAcrossScreens() const bool ShellClient::isResizable() const { + if (isFullScreen()) { + return false; + } if (rules()->checkSize(QSize()).isValid()) { return false; }