yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove PaintClipper from CoverSwitch

Browse source 
Reflection in a vertical multiscreen setup are kind of broken without
PaintClipper. But we have to ask ourselfe whether CoverSwitch in a
vertical multi screen setup makes sense and whether it's useful to
have reflections in such a setup.

Horizontal multiscreen setup works fine (also with reflections).
This commit is contained in:
Martin Gräßlin 2011-06-26 14:59:39 +02:00
parent 9c8ebfc1fd
commit 8fa22d0f6a
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
effects/coverswitch/coverswitch.cpp
View file

@ -260,14 +260,10 @@ void CoverSwitchEffect::paintScreen(int mask, QRegion region, ScreenPaintData& d
} }
if (reflection) { if (reflection) {
// restrict painting the reflections to the current screen
QRegion clip = QRegion(area);
PaintClipper::push(clip);
// no reflections during start and stop animation // no reflections during start and stop animation
// except when using a shader // except when using a shader
if ((!start && !stop) || ShaderManager::instance()->isValid()) if ((!start && !stop) || ShaderManager::instance()->isValid())
paintScene(frontWindow, leftWindows, rightWindows, true); paintScene(frontWindow, leftWindows, rightWindows, true);
PaintClipper::pop(clip);
glEnable(GL_BLEND); glEnable(GL_BLEND);
glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA); glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
#ifndef KWIN_HAVE_OPENGLES #ifndef KWIN_HAVE_OPENGLES