From 9098fd491039e1ea9ba7f9599e40abb4ceeb815c Mon Sep 17 00:00:00 2001
From: Ismael Asensio <isma.af@gmail.com>
Date: Sun, 21 Jul 2024 13:49:26 +0200
Subject: [PATCH] kcms/rules: Make the "Add Property" button non-toggleable

Changing the text and meaning of the button unexpectedly for a
regular operation is not consistent with any other place, and
disregarded by the HIG.

The sheet can be closed by tapping outside of it, or throught
the close button in its titlebar, as usual elsewhere.
---
 src/kcms/rules/ui/RulesEditor.qml | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/kcms/rules/ui/RulesEditor.qml b/src/kcms/rules/ui/RulesEditor.qml
index 5dd20656d5..e5f3e7e02c 100644
--- a/src/kcms/rules/ui/RulesEditor.qml
+++ b/src/kcms/rules/ui/RulesEditor.qml
@@ -85,12 +85,10 @@ KCM.ScrollViewKCM {
 
     footer:  RowLayout {
         QQC2.Button {
-            text: checked ? i18n("Close") : i18n("Add Property...")
-            icon.name: checked ? "dialog-close" : "list-add"
-            checkable: true
-            checked: propertySheet.visible
-            onToggled: {
-                propertySheet.visible = checked;
+            text: i18n("Add Property...")
+            icon.name: "list-add"
+            onClicked: {
+                propertySheet.visible = true;
             }
         }
         Item {