From 919b497f9020a4be49c66d7e07f8a15aced317f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Sat, 15 Apr 2017 11:59:45 +0200 Subject: [PATCH] [effects/slideback] Consider windows which do have painting disabled as not usable Summary: On Wayland it can happen that a window is still in the stacking order although it is not visible. This is mostly the case for Plasma windows. So far the slideback effect did not ignore those windows and as they are higher in the stacking order than most other windows it blocked the effect from working once a Plasma panel element got closed. This change considers a window which has painting disabled in the stacking order as not usable and thus filters out all those windows. BUG: 364483 Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D5462 --- effects/slideback/slideback.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/effects/slideback/slideback.cpp b/effects/slideback/slideback.cpp index 97400bc62d..e7313c0cbf 100644 --- a/effects/slideback/slideback.cpp +++ b/effects/slideback/slideback.cpp @@ -295,7 +295,7 @@ void SlideBackEffect::slotTabBoxClosed() bool SlideBackEffect::isWindowUsable(EffectWindow* w) { return w && (w->isNormalWindow() || w->isDialog()) && !w->keepAbove() && !w->isDeleted() && !w->isMinimized() - && w->isCurrentTab(); + && w->isCurrentTab() && w->isPaintingEnabled(); } bool SlideBackEffect::intersects(EffectWindow* windowUnder, const QRect &windowOverGeometry)