yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugins/screencast: Don't download texture data if target size and texture size mismatch

Browse source 
If glGetTexImage() gets called, it can write beyond the bounds of the
target size. In long term, it would be nice to relax this check.

CCBUG: 489764
This commit is contained in:
Vlad Zahorodnii 2024-07-10 17:58:17 +03:00
parent a6743fd2f5
commit 9240d75e51
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/plugins/screencast/screencastutils.h
View file

@ -41,6 +41,10 @@ static GLenum closestGLType(QImage::Format format)
static void doGrabTexture(GLTexture *texture, QImage *target) static void doGrabTexture(GLTexture *texture, QImage *target)
{ {
if (texture->size() != target->size()) {
return;
}
const auto context = OpenGlContext::currentContext(); const auto context = OpenGlContext::currentContext();
const QSize size = texture->size(); const QSize size = texture->size();
const bool invertNeeded = context->isOpenGLES() ^ (texture->contentTransform() != OutputTransform::FlipY); const bool invertNeeded = context->isOpenGLES() ^ (texture->contentTransform() != OutputTransform::FlipY);