yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent potential QMap detaching

Browse source 
Store resourceMap() in a local const variable to avoid detaching.
This commit is contained in:
Vlad Zahorodnii 2021-05-05 23:00:39 +03:00
parent cdafb5d0da
commit 94c92393b1
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/wayland/xdgoutput_v1_interface.cpp
View file

@ -121,7 +121,9 @@ void XdgOutputV1Interface::setLogicalSize(const QSize &size)
} }
d->size = size; d->size = size;
d->dirty = true; d->dirty = true;
for (auto resource : d->resourceMap()) {
const auto outputResources = d->resourceMap();
for (auto resource : outputResources) {
d->send_logical_size(resource->handle, size.width(), size.height()); d->send_logical_size(resource->handle, size.width(), size.height());
} }
} }
@ -138,7 +140,9 @@ void XdgOutputV1Interface::setLogicalPosition(const QPoint &pos)
} }
d->pos = pos; d->pos = pos;
d->dirty = true; d->dirty = true;
for (auto resource : d->resourceMap()) {
const auto outputResources = d->resourceMap();
for (auto resource : outputResources) {
d->send_logical_position(resource->handle, pos.x(), pos.y()); d->send_logical_position(resource->handle, pos.x(), pos.y());
} }
} }
@ -167,7 +171,9 @@ void XdgOutputV1Interface::done()
return; return;
} }
d->dirty = false; d->dirty = false;
for (auto resource : d->resourceMap()) {
const auto outputResources = d->resourceMap();
for (auto resource : outputResources) {
if (wl_resource_get_version(resource->handle) < 3) { if (wl_resource_get_version(resource->handle) < 3) {
d->send_done(resource->handle); d->send_done(resource->handle);
} }