yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[effects/blur] Lookup window once when disconnecting from blurChanged

Browse source 
Summary:
When disconnecting from `blurChanged` signal, `(w, connection)` pair is
being looked up three times. We can do better by using `QMap` in a more
STL-like way.

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13118
This commit is contained in:
Vlad Zagorodniy 2018-05-25 19:49:44 +03:00
parent 54b69bec44
commit 95ee052442
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
effects/blur/blur.cpp
View file

@ -303,10 +303,12 @@ void BlurEffect::slotWindowAdded(EffectWindow *w)
void BlurEffect::slotWindowDeleted(EffectWindow *w) void BlurEffect::slotWindowDeleted(EffectWindow *w)
{ {
if (windowBlurChangedConnections.contains(w)) { auto it = windowBlurChangedConnections.find(w);
disconnect(windowBlurChangedConnections[w]); if (it == windowBlurChangedConnections.end()) {
windowBlurChangedConnections.remove(w); return;
} }
disconnect(*it);
windowBlurChangedConnections.erase(it);
} }
void BlurEffect::slotPropertyNotify(EffectWindow *w, long atom) void BlurEffect::slotPropertyNotify(EffectWindow *w, long atom)