From 97cf32f9162ebb533e7ce88288602a731e3a2e74 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Fri, 1 Feb 2019 01:04:15 +0200 Subject: [PATCH] Drop ShellClient::shellSurface method Summary: The only place where this method is used is testMaximize. Though that usage is not justified. We're checking what KWayland already checks. Test Plan: Compiles, all tests still pass. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D18635 --- autotests/integration/maximize_test.cpp | 1 - shell_client.h | 4 ---- 2 files changed, 5 deletions(-) diff --git a/autotests/integration/maximize_test.cpp b/autotests/integration/maximize_test.cpp index b76f3a8043..b3e39e0d06 100644 --- a/autotests/integration/maximize_test.cpp +++ b/autotests/integration/maximize_test.cpp @@ -174,7 +174,6 @@ void TestMaximized::testInitiallyMaximized() QCOMPARE(client->geometry(), QRect(0, 0, 100, 50)); QEXPECT_FAIL("", "Should go out of maximzied", Continue); QCOMPARE(client->maximizeMode(), MaximizeMode::MaximizeRestore); - QVERIFY(client->shellSurface()->isMaximized()); } void TestMaximized::testBorderlessMaximizedWindow() diff --git a/shell_client.h b/shell_client.h index 4b8655ab13..45b9b66170 100644 --- a/shell_client.h +++ b/shell_client.h @@ -69,10 +69,6 @@ public: void setOpacity(double opacity) override; QByteArray windowRole() const override; - KWayland::Server::ShellSurfaceInterface *shellSurface() const { - return m_shellSurface; - } - void blockActivityUpdates(bool b = true) override; QString captionNormal() const override { return m_caption;