From a03d70c9a6d71e8e898e07f3a7eab39b910ee84d Mon Sep 17 00:00:00 2001 From: Vlad Zahorodnii Date: Fri, 27 Sep 2019 17:01:54 +0300 Subject: [PATCH] Delete pointless discardShape method calls Summary: There's no point for calling discardShape from the destructor of a Scene::Window subclass because window quads cache will be destroyed automagically by QScopedPointer. Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D24317 --- plugins/scenes/qpainter/scene_qpainter.cpp | 1 - plugins/scenes/xrender/scene_xrender.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/plugins/scenes/qpainter/scene_qpainter.cpp b/plugins/scenes/qpainter/scene_qpainter.cpp index 8588ed96d8..98c39f45b5 100644 --- a/plugins/scenes/qpainter/scene_qpainter.cpp +++ b/plugins/scenes/qpainter/scene_qpainter.cpp @@ -223,7 +223,6 @@ SceneQPainter::Window::Window(SceneQPainter *scene, Toplevel *c) SceneQPainter::Window::~Window() { - discardShape(); } static void paintSubSurface(QPainter *painter, const QPoint &pos, QPainterWindowPixmap *pixmap) diff --git a/plugins/scenes/xrender/scene_xrender.cpp b/plugins/scenes/xrender/scene_xrender.cpp index 55ae3f7752..506b8ec675 100644 --- a/plugins/scenes/xrender/scene_xrender.cpp +++ b/plugins/scenes/xrender/scene_xrender.cpp @@ -327,7 +327,6 @@ SceneXrender::Window::Window(Toplevel* c, SceneXrender *scene) SceneXrender::Window::~Window() { - discardShape(); } void SceneXrender::Window::cleanup()