yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove AbstractClient plumbing casts in DbusInterface

Browse source
This commit is contained in:
Vlad Zahorodnii 2022-04-18 11:24:28 +03:00
parent 348e20e20f
commit a429739f98
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/dbusinterface.cpp
View file

@ -235,16 +235,18 @@ QVariantMap DBusInterface::queryWindowInfo()
setDelayedReply(true); setDelayedReply(true);
kwinApp()->platform()->startInteractiveWindowSelection( kwinApp()->platform()->startInteractiveWindowSelection(
[this](AbstractClient *t) { [this](AbstractClient *t) {
if (auto c = static_cast<AbstractClient *>(t->isClient() ? t : nullptr)) { if (!t) {
QDBusConnection::sessionBus().send(m_replyQueryWindowInfo.createReply(clientToVariantMap(c)));
} else if (qobject_cast<Unmanaged *>(t)) {
QDBusConnection::sessionBus().send(m_replyQueryWindowInfo.createErrorReply(
QStringLiteral("org.kde.KWin.Error.InvalidWindow"),
QStringLiteral("Tried to query information about an unmanaged window")));
} else {
QDBusConnection::sessionBus().send(m_replyQueryWindowInfo.createErrorReply( QDBusConnection::sessionBus().send(m_replyQueryWindowInfo.createErrorReply(
QStringLiteral("org.kde.KWin.Error.UserCancel"), QStringLiteral("org.kde.KWin.Error.UserCancel"),
QStringLiteral("User cancelled the query"))); QStringLiteral("User cancelled the query")));
return;
}
if (t->isClient()) {
QDBusConnection::sessionBus().send(m_replyQueryWindowInfo.createReply(clientToVariantMap(t)));
} else {
QDBusConnection::sessionBus().send(m_replyQueryWindowInfo.createErrorReply(
QStringLiteral("org.kde.KWin.Error.InvalidWindow"),
QStringLiteral("Tried to query information about an unmanaged window")));
} }
}); });
return QVariantMap{}; return QVariantMap{};