yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugins/screencast: Allocate offscreen texture in WindowScreenCastSource::render(QImage) as big as the memfd buffer

Browse source 
textureSize() can temporarily mismatch the target buffer size. It can be
a problem if glGetTexImage() gets called. glGetTexImage() assumes that
the provided buffer is as big as the texture. If it's not, it will write
data outside the bounds of the buffer.

BUG: 489764
This commit is contained in:
Vlad Zahorodnii 2024-07-10 17:40:46 +03:00
parent abd790c4b5
commit a6743fd2f5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/plugins/screencast/windowscreencastsource.cpp
View file

@ -59,7 +59,7 @@ qreal WindowScreenCastSource::devicePixelRatio() const
void WindowScreenCastSource::render(QImage *target) void WindowScreenCastSource::render(QImage *target)
{ {
const auto offscreenTexture = GLTexture::allocate(GL_RGBA8, textureSize()); const auto offscreenTexture = GLTexture::allocate(GL_RGBA8, target->size());
if (!offscreenTexture) { if (!offscreenTexture) {
return; return;
} }