From a81ddf294946e900b0b777f1fb0375a923bbda70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Gr=C3=A4=C3=9Flin?= Date: Sun, 15 May 2011 09:40:19 +0200 Subject: [PATCH] Disable Unredirect Fullscreen Windows by default Well we don't have another choice if half of the drivers crash kwin whenever you watch a fullscreen flash video or use a screen saver. Unredirect Fullscreen Window was quite useful in case you used to play heavy OpenGL games, but pretty useless for anything else. For the game and hd video usecase we nowadays have the better way of really suspending compositing (either by the client indicating or with a window specific rule). The plus of suspending compositing is that the driver doesn't crash. And yes we are "supposed" to no longer workaround driver bugs. Good joke, I like to redirect my inbox to everyone who things we are not allowed to workaround driver bugs. CCBUG: 252817 --- kcmkwin/kwincompositing/main.cpp | 4 ++-- options.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kcmkwin/kwincompositing/main.cpp b/kcmkwin/kwincompositing/main.cpp index a2bba83ad8..3acf94c404 100644 --- a/kcmkwin/kwincompositing/main.cpp +++ b/kcmkwin/kwincompositing/main.cpp @@ -392,7 +392,7 @@ void KWinCompositingConfig::loadAdvancedTab() else // shown, or default ui.windowThumbnails->setCurrentIndex(1); ui.disableChecks->setChecked(config.readEntry("DisableChecks", false)); - ui.unredirectFullscreen->setChecked(config.readEntry("UnredirectFullscreen", true)); + ui.unredirectFullscreen->setChecked(config.readEntry("UnredirectFullscreen", false)); ui.xrScaleFilter->setCurrentIndex((int)config.readEntry("XRenderSmoothScale", false)); ui.glScaleFilter->setCurrentIndex(config.readEntry("GLTextureFilter", 2)); @@ -723,7 +723,7 @@ void KWinCompositingConfig::defaults() ui.compositingType->setCurrentIndex(0); ui.windowThumbnails->setCurrentIndex(1); ui.disableChecks->setChecked(false); - ui.unredirectFullscreen->setChecked(true); + ui.unredirectFullscreen->setChecked(false); ui.xrScaleFilter->setCurrentIndex(0); ui.glScaleFilter->setCurrentIndex(2); ui.glDirect->setChecked(mDefaultPrefs.enableDirectRendering()); diff --git a/options.cpp b/options.cpp index 7846c6c5ca..a4cee3c38e 100644 --- a/options.cpp +++ b/options.cpp @@ -349,7 +349,7 @@ void Options::reloadCompositingSettings(bool force) else if (hps == 6) hiddenPreviews = HiddenPreviewsAlways; - unredirectFullscreen = config.readEntry("UnredirectFullscreen", true); + unredirectFullscreen = config.readEntry("UnredirectFullscreen", false); animationSpeed = qBound(0, config.readEntry("AnimationSpeed", 3), 6); }