yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[effects] Drop loading shadow config from MagicLamp

Browse source 
Summary:
This has basically been dead code for ages. The Shadow effect got
dropped in an early 4.x version. We shouldn't transform the window based
on old shadow values, so completely removed.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3339
This commit is contained in:
Martin Gräßlin 2016-11-11 11:14:30 +01:00
parent 2b93939a67
commit a8fa1626eb
2 changed files with 1 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
effects/magiclamp/magiclamp.cpp
View file

@ -51,19 +51,6 @@ void MagicLampEffect::reconfigure(ReconfigureFlags)
MagicLampConfig::self()->read();
// TODO: rename animationDuration to duration
mAnimationDuration = animationTime(MagicLampConfig::animationDuration() != 0 ? MagicLampConfig::animationDuration() : 250);
KConfigGroup conf = effects->effectConfig(QStringLiteral("MagicLamp"));
conf = effects->effectConfig(QStringLiteral("Shadow"));
int v = conf.readEntry("Size", 5);
v += conf.readEntry("Fuzzyness", 10);
mShadowOffset[0] = mShadowOffset[1] = -v;
mShadowOffset[2] = mShadowOffset[3] = v;
v = conf.readEntry("XOffset", 0);
mShadowOffset[0] -= v;
mShadowOffset[2] += v;
v = conf.readEntry("YOffset", 3);
mShadowOffset[1] -= v;
mShadowOffset[3] += v;
}
void MagicLampEffect::prePaintScreen(ScreenPrePaintData& data, int time)
@ -121,7 +108,7 @@ void MagicLampEffect::paintWindow(EffectWindow* w, int mask, QRegion region, Win
IconPosition position = Top;
// If there's no icon geometry, minimize to the center of the screen
if (!icon.isValid()) {
QRect extG = geo.adjusted(mShadowOffset[0], mShadowOffset[1], mShadowOffset[2], mShadowOffset[3]);
QRect extG = geo;
QPoint pt = cursorPos();
// focussing inside the window is no good, leads to ugly artefacts, find nearest border
if (extG.contains(pt)) {

1
effects/magiclamp/magiclamp.h
View file

@ -62,7 +62,6 @@ private:
QHash< EffectWindow*, QTimeLine* > mTimeLineWindows;
int mActiveAnimations;
int mAnimationDuration;
int mShadowOffset[4];
enum IconPosition {
Top,