yukijoou/kwin
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

platformsupport/scene/opengl: do test imports for external_only formats properly

Browse source 
The scene renderer doesn't use external_only formats as a single EGLImage, but only does
YUV conversion for some specific formats, so the test import should match that.
This commit is contained in:
Xaver Hugl 2024-08-14 23:27:41 +02:00
parent 61ef8c0087
commit ad27858df3
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/platformsupport/scenes/opengl/abstract_egl_backend.cpp
View file

@ -309,7 +309,25 @@ std::shared_ptr<GLTexture> AbstractEglBackend::importDmaBufAsTexture(const DmaBu
bool AbstractEglBackend::testImportBuffer(GraphicsBuffer *buffer)
{
return importBufferAsImage(buffer) != EGL_NO_IMAGE_KHR;
const auto nonExternalOnly = m_display->nonExternalOnlySupportedDrmFormats();
if (auto it = nonExternalOnly.find(buffer->dmabufAttributes()->format); it != nonExternalOnly.end() && it->contains(buffer->dmabufAttributes()->modifier)) {
return importBufferAsImage(buffer) != EGL_NO_IMAGE_KHR;
}
// external_only buffers aren't used as a single EGLImage, import them separately
const auto info = FormatInfo::get(buffer->dmabufAttributes()->format);
if (!info || !info->yuvConversion()) {
return false;
}
const auto planes = info->yuvConversion()->plane;
if (buffer->dmabufAttributes()->planeCount != planes.size()) {
return false;
}
for (int i = 0; i < planes.size(); i++) {
if (!importBufferAsImage(buffer, i, planes[i].format, QSize(buffer->size().width() / planes[i].widthDivisor, buffer->size().height() / planes[i].heightDivisor))) {
return false;
}
}
return true;
}
QHash<uint32_t, QList<uint64_t>> AbstractEglBackend::supportedFormats() const